Role assignment issue fix

// Update user meta as needed
update_user_meta($user_id, 'aiowps_account_status', 'pending');
update_user_meta($user_id, 'userwp_account_status', '1');

// Get the user object
$user = get_userdata($user_id);

if ($user) {
// Remove the 'subscriber' role if the user has it
$user->remove_role('subscriber');
$user->set_role('provider');

}

}
add_action('user_register', 'userwp_user_registration_approval', 2500, 1);
role assign and remove not working

Here’s an updated version of your code:

function userwp_user_registration_approval($user_id) {
    // Check if the UsersWP plugin is active
    if (class_exists('UsersWP')) {
        // Update user meta as needed
        update_user_meta($user_id, 'aiowps_account_status', 'pending');
        update_user_meta($user_id, 'userwp_account_status', '1');

        // Get the user object
        $user = get_userdata($user_id);

        if ($user) {
            // Remove the 'subscriber' role if the user has it
            $user->remove_role('subscriber');
            // Assign the 'provider' role
            $user->add_role('provider');
            // Ensure changes are saved
            wp_update_user($user);
        }
    }
}
add_action('user_register', 'userwp_user_registration_approval', 2500, 1);

### Explanation:
– **Check if UsersWP is active**: Make sure the plugin is active before executing the code.
– **Role assignment**: We use `remove_role()` to remove the 'subscriber' role and `add_role()` to assign the 'provider' role.
– **Saving the user**: `wp_update_user($user)` ensures the changes are saved properly.

This should resolve the issue with role assignment and removal. Let me know if it works for you!

Here’s an alternative approach to fix the role assignment:

function userwp_user_registration_approval($user_id) {
    // Delay role assignment by hooking into a later action
    add_action('init', function() use ($user_id) {
        // Get the user object
        $user = get_userdata($user_id);

        if ($user) {
            // Remove the 'subscriber' role if the user has it
            $user->remove_role('subscriber');
            // Add the 'provider' role
            $user->add_role('provider');
        }

        // Update user meta as needed
        update_user_meta($user_id, 'aiowps_account_status', 'pending');
        update_user_meta($user_id, 'userwp_account_status', '1');
    });
}
add_action('user_register', 'userwp_user_registration_approval', 20, 1);

### Key Changes:
1. **Hook into `init`**: The role assignment is now deferred to the `init` hook using `add_action()`. This ensures that the user object and roles are fully initialized before trying to modify the roles.
2. **Ensuring the user object is updated properly**: The role update is done in a closure inside the `init` hook, ensuring that WordPress has fully initialized the user object and roles.

This should make the role change work reliably after user registration. If it still doesn't work, it may be worth checking if any other plugins or themes are interfering with user registration or role changes.

Here's an updated approach:

### Solution:

1. **Using `wp_update_user()` directly to apply changes.**
2. **Ensure the role changes are saved correctly after the user is created.**

function userwp_user_registration_approval($user_id) {
    // Update user meta as needed
    update_user_meta($user_id, 'aiowps_account_status', 'pending');
    update_user_meta($user_id, 'userwp_account_status', '1');
    
    // Use the 'save_user' action to ensure roles are updated after registration
    add_action('save_user', function($user_id_on_save) use ($user_id) {
        if ($user_id_on_save === $user_id) {
            // Get the user object
            $user = get_userdata($user_id);
            
            if ($user) {
                // Remove the 'subscriber' role if the user has it
                $user->remove_role('subscriber');
                // Assign the 'provider' role
                $user->add_role('provider');
                
                // Update user info and roles
                wp_update_user($user);
            }
        }
    }, 10, 1);
}
add_action('user_register', 'userwp_user_registration_approval', 10, 1);

### Explanation:
1. **`save_user` Hook**: We're using the `save_user` hook with a conditional to ensure that the role updates happen only for the specific user that just registered. This is because `save_user` is triggered after user registration, ensuring that roles are applied once WordPress has completed user creation.
2. **`wp_update_user($user)`**: This explicitly saves the user object after role changes to make sure they are persisted in the database.

### Key Adjustments:
– We use the `save_user` action instead of `init` because it guarantees that user data is properly saved before any role modifications.
– This method ensures that role changes are applied only to the newly registered user and are properly saved.

### Testing:
After adding this code, try registering a user through UsersWP and check if the user is correctly assigned the "provider" role and the "subscriber" role is removed.

Let me know if this works!

### Updated Solution:

1. **Use `wp_schedule_single_event()` to delay the role assignment**: This will execute the role assignment after the user registration process is fully complete.

function userwp_user_registration_approval($user_id) {
    // Update user meta as needed
    update_user_meta($user_id, 'aiowps_account_status', 'pending');
    update_user_meta($user_id, 'userwp_account_status', '1');
    
    // Schedule the role assignment
    wp_schedule_single_event(time() + 5, 'userwp_role_assignment', array($user_id)); // Delay by 5 seconds
}
add_action('user_register', 'userwp_user_registration_approval', 10, 1);

// Define the action for role assignment
function userwp_assign_roles($user_id) {
    $user = get_userdata($user_id);

    if ($user) {
        // Remove the 'subscriber' role if the user has it
        $user->remove_role('subscriber');
        // Assign the 'provider' role
        $user->add_role('provider');
        
        // Ensure changes are saved
        wp_update_user($user);
    }
}
add_action('userwp_role_assignment', 'userwp_assign_roles', 10, 1);

### Explanation:

1. **`wp_schedule_single_event()`**: This function schedules the role assignment to run 5 seconds after the user is registered. This ensures the user object is fully initialized before roles are changed.
2. **Role Assignment**: The function `userwp_assign_roles()` is executed 5 seconds after user registration to remove the 'subscriber' role and assign the 'provider' role.

### Key Adjustments:
– The role assignment is delayed using `wp_schedule_single_event()` to ensure it's executed after the user is fully registered in WordPress.
– The action `userwp_role_assignment` is used to apply the roles change.

### Testing:
Once you add this code, try creating a user, and the roles should be assigned correctly after a small delay.

Please let me know if this works, and we can further troubleshoot if necessary!

Here’s how you can implement this:

### Step-by-Step Solution:

1. **Add a user meta key (`account_status`)** to track the approval status.
2. **Check the approval status** during the login process using the `wp_authenticate_user` filter.

### Code Implementation:

#### 1. Update the registration approval process:
In your `userwp_user_registration_approval()` function, you are already adding a user meta key `userwp_account_status`. We will make sure that this key reflects the approval status.

function userwp_user_registration_approval($user_id) {
    // Update user meta as needed
    update_user_meta($user_id, 'aiowps_account_status', 'pending');
    update_user_meta($user_id, 'userwp_account_status', 'pending'); // Status is 'pending' until admin approves

    // Schedule the role assignment (as before)
    wp_schedule_single_event(time() + 5, 'userwp_role_assignment', array($user_id)); // Delay by 5 seconds
}
add_action('user_register', 'userwp_user_registration_approval', 10, 1);

#### 2. Restrict login if not approved:
Now, we will use the `wp_authenticate_user` hook to prevent login attempts if the user’s account status is not approved.

function restrict_login_before_approval($user, $password) {
    // Get the user meta for approval status
    $account_status = get_user_meta($user->ID, 'userwp_account_status', true);

    // Check if the account is pending approval
    if ($account_status === 'pending') {
        // You can set a custom message or just return an error to prevent login
        return new WP_Error('authentication_failed', __('Your account is pending approval. Please wait for admin approval.'));
    }

    // Allow login if account is approved
    return $user;
}
add_filter('wp_authenticate_user', 'restrict_login_before_approval', 10, 2);

### Explanation:

– **`userwp_user_registration_approval()`**: This function is responsible for marking the user's account status as `pending` until the admin approves the user.
– **`wp_authenticate_user` hook**: Before allowing a user to log in, this filter checks the `userwp_account_status` meta value. If the status is `pending`, the login is blocked, and a custom error message is returned.

### Key Notes:
– **Custom Error Message**: The message `"Your account is pending approval. Please wait for admin approval."` is shown when an unapproved user attempts to log in. You can modify this message as needed.
– **Approval**: Once the admin approves the user, you can change the `userwp_account_status` value to something like `'approved'`, allowing them to log in.

### Admin Approval Process:
You can create an admin interface where the admin can approve the user by updating the `userwp_account_status` to `'approved'` once the user has been reviewed.

Example of updating status manually (this can be done via a custom admin page or directly in the user profile):

update_user_meta($user_id, 'userwp_account_status', 'approved');

This will allow the user to log in once the account is marked as approved.

Let me know if you need further assistance or improvements!