Merchant Feed Logging

August 7, 2025 · AI Conversations

User
'application/xml']
);
}
}
apply proper error handlign and save log in
$db->executeQuery("CREATE TABLE IF NOT EXISTS shoppingfeedlog (
id INT AUTO_INCREMENT PRIMARY KEY,
feed_id INT NOT NULL,
updated_at DATETIME NOT NULL,
status VARCHAR(50),
error_message TEXT,
INDEX idx_feed (feed_id),
INDEX idx_status (status),
INDEX idx_updated_at (updated_at),
FOREIGN KEY (feed_id) REFERENCES shoppingfeedconfiguration(id) ON DELETE CASCADE
)");
Assistant
Here’s the updated `MerchantFeed` controller with **proper error handling**, **logging**, and **creation of the `shoppingfeedlog` table** (if not already present). I've wrapped the XML generation logic in a try-catch block and added a reusable method to log success/failure events:

—

### ✅ Full Controller with Logging and Error Handling:

<?php
namespace ConcretePackageShoppingFeedManagerController;

use ConcreteCoreControllerAbstractController;
use ConcreteCoreDatabaseConnectionConnection;
use SymfonyComponentHttpFoundationResponse;
use ConcretePackageCommunityStoreSrcCommunityStoreProductProduct;
use ConcreteCoreSupportFacadeUrl;
use ConcreteCorePagePage;
use Exception;
use DateTime;

class MerchantFeed extends AbstractController
{
    protected function logFeedStatus($db, $feedId, $status, $message = null)
    {
        $now = (new DateTime())->format('Y-m-d H:i:s');

        // Ensure log table exists
        $db->executeQuery("CREATE TABLE IF NOT EXISTS shoppingfeedlog (
            id INT AUTO_INCREMENT PRIMARY KEY,
            feed_id INT NOT NULL,
            updated_at DATETIME NOT NULL,
            status VARCHAR(50),
            error_message TEXT,
            INDEX idx_feed (feed_id),
            INDEX idx_status (status),
            INDEX idx_updated_at (updated_at),
            FOREIGN KEY (feed_id) REFERENCES shoppingfeedconfiguration(id) ON DELETE CASCADE
        )");

        // Insert log entry
        $db->insert('shoppingfeedlog', [
            'feed_id' => $feedId,
            'updated_at' => $now,
            'status' => $status,
            'error_message' => $message
        ]);
    }

    public function generateXml($feedSlug = null)
    {
        $baseUrl = Url::to('/');
        $db = Core::make(Connection::class);

        try {
            if (!$feedSlug) {
                throw new Exception("Feed slug is required.");
            }

            $config = $db->fetchAssociative("SELECT * FROM shoppingfeedconfiguration WHERE feedSlug = ?", [$feedSlug]);
            if (!$config) {
                throw new Exception("Feed not found.");
            }

            $settings = unserialize($config['settings']);
            $baseSelect = "SELECT p.*";
            $baseFrom   = "FROM CommunityStoreProducts p";
            $joins      = [];
            $conditions = ["1=1"];
            $params     = [];

            // Price range
            if (!empty($settings['price_range']['min']) && !empty($settings['price_range']['max'])) {
                $conditions[] = "p.pPrice BETWEEN ? AND ?";
                $params[] = (float)$settings['price_range']['min'];
                $params[] = (float)$settings['price_range']['max'];
            }

            if (!empty($settings['product_groups'])) {
                $groupIds = array_map('intval', $settings['product_groups']);
                $joins[] = "INNER JOIN CommunityStoreProductGroups pg ON pg.pID = p.pID";
                $conditions[] = "pg.gID IN (" . implode(',', $groupIds) . ")";
            }

            if (!empty($settings['product_types'])) {
                $productTypes = array_map('intval', $settings['product_types']);
                $conditions[] = "p.pType IN (" . implode(',', $productTypes) . ")";
            }

            if (!empty($settings['pShippable'])) {
                $conditions[] = "p.pShippable = '" . $settings['pShippable'] . "'";
            }

            if (!empty($settings['pTaxable'])) {
                $conditions[] = "p.pTaxable = '" . $settings['pTaxable'] . "'";
            }

            if (!empty($settings['pFeatured'])) {
                $conditions[] = "p.pFeatured = '" . $settings['pFeatured'] . "'";
            }

            $sql = "
                $baseSelect
                $baseFrom
                " . implode(" ", $joins) . "
                WHERE " . implode(" AND ", $conditions) . "
                GROUP BY p.pID
                ORDER BY p.pID DESC
            ";

            $products = $db->fetchAll($sql, $params);

            // Build XML
            $xml = new SimpleXMLElement('<?xml version="1.0" encoding="UTF-8"?><rss version="2.0"/>');
            $xml->addAttribute('xmlns:g', 'http://base.google.com/ns/1.0');

            $channel = $xml->addChild('channel');
            $channel->addChild('title', 'Your Store Feed');
            $channel->addChild('link', $baseUrl);
            $channel->addChild('description', 'Product feed for Google Merchant Center');

            foreach ($products as $product) {
                $productu = Product::getByID($product['pID']);
                $page = Page::getByID($productu->getPageID());
                if (!$page || $page->isError()) {
                    continue;
                }

                $url = $page->getCollectionLink();
                $imageUrl = '';
                $image = $productu->getImageObj();
                if (is_object($image)) {
                    $imageUrl = $image->getURL();
                }

                $brand = '';
                if (is_numeric($product['pManufacturer'])) {
                    $manufacturer = $db->fetchAssociative("SELECT * FROM CommunityStoreManufacturer WHERE mID = ?", [$product['pManufacturer']]);
                    if (is_array($manufacturer)) {
                        $brand = $manufacturer['mName'];
                    }
                }

                $item = $channel->addChild('item');
                $item->addChild('g:id', $product['pID'], 'http://base.google.com/ns/1.0');
                $item->addChild('title', htmlspecialchars($product['pName']));
                $item->addChild('description', htmlspecialchars($product['pDesc']));
                $item->addChild('link', htmlspecialchars($url));
                $item->addChild('g:image_link', htmlspecialchars($imageUrl), 'http://base.google.com/ns/1.0');
                $item->addChild('g:availability', 'in stock', 'http://base.google.com/ns/1.0');
                $item->addChild('g:price', $product['pPrice'] . ' USD', 'http://base.google.com/ns/1.0');
                $item->addChild('g:brand', htmlspecialchars($brand), 'http://base.google.com/ns/1.0');
                $item->addChild('g:condition', 'new', 'http://base.google.com/ns/1.0');
            }

            $xmlContent = $xml->asXML();
            $this->logFeedStatus($db, $config['id'], 'success');

            return new Response(
                $xmlContent,
                200,
                ['Content-Type' => 'application/xml']
            );
        } catch (Exception $e) {
            // Log error
            if (isset($db) && isset($config['id'])) {
                $this->logFeedStatus($db, $config['id'], 'error', $e->getMessage());
            }

            return new Response("Error generating feed: " . $e->getMessage(), 500);
        }
    }
}

—

### 🔒 Summary of Enhancements:
– ✅ **Error handling via `try-catch`**
– ✅ **Database logging for both success and failure**
– ✅ **Automatic creation of `shoppingfeedlog` table**
– ✅ **Keeps controller code clean and manageable**

Let me know if you'd like to also add an interface in the Dashboard to view logs, or automatically clear old logs after X days.

User
dont creeate table just insert proper log
Assistant
Got it! Here's your updated `MerchantFeed` controller with **error logging** logic but **without creating the table**. It assumes the table `shoppingfeedlog` **already exists** with columns:

id, feed_id, updated_at, status, error_message

—

### ✅ Updated `MerchantFeed` Controller (Only Log, No Table Creation)

<?php
namespace ConcretePackageShoppingFeedManagerController;

use ConcreteCoreControllerAbstractController;
use ConcreteCoreDatabaseConnectionConnection;
use SymfonyComponentHttpFoundationResponse;
use ConcretePackageCommunityStoreSrcCommunityStoreProductProduct;
use ConcreteCoreSupportFacadeUrl;
use ConcreteCorePagePage;
use Exception;
use DateTime;

class MerchantFeed extends AbstractController
{
    protected function logFeedStatus($db, $feedId, $status, $message = null)
    {
        try {
            $now = (new DateTime())->format('Y-m-d H:i:s');

            $db->insert('shoppingfeedlog', [
                'feed_id' => $feedId,
                'updated_at' => $now,
                'status' => $status,
                'error_message' => $message
            ]);
        } catch (Exception $logException) {
            // Optional: Log error to file or skip silently
            // error_log("Feed log error: " . $logException->getMessage());
        }
    }

    public function generateXml($feedSlug = null)
    {
        $baseUrl = Url::to('/');
        $db = Core::make(Connection::class);

        try {
            if (!$feedSlug) {
                throw new Exception("Feed slug is required.");
            }

            $config = $db->fetchAssociative("SELECT * FROM shoppingfeedconfiguration WHERE feedSlug = ?", [$feedSlug]);
            if (!$config) {
                throw new Exception("Feed not found.");
            }

            $settings = unserialize($config['settings']);
            $baseSelect = "SELECT p.*";
            $baseFrom   = "FROM CommunityStoreProducts p";
            $joins      = [];
            $conditions = ["1=1"];
            $params     = [];

            if (!empty($settings['price_range']['min']) && !empty($settings['price_range']['max'])) {
                $conditions[] = "p.pPrice BETWEEN ? AND ?";
                $params[] = (float)$settings['price_range']['min'];
                $params[] = (float)$settings['price_range']['max'];
            }

            if (!empty($settings['product_groups'])) {
                $groupIds = array_map('intval', $settings['product_groups']);
                $joins[] = "INNER JOIN CommunityStoreProductGroups pg ON pg.pID = p.pID";
                $conditions[] = "pg.gID IN (" . implode(',', $groupIds) . ")";
            }

            if (!empty($settings['product_types'])) {
                $productTypes = array_map('intval', $settings['product_types']);
                $conditions[] = "p.pType IN (" . implode(',', $productTypes) . ")";
            }

            if (!empty($settings['pShippable'])) {
                $conditions[] = "p.pShippable = '" . $settings['pShippable'] . "'";
            }

            if (!empty($settings['pTaxable'])) {
                $conditions[] = "p.pTaxable = '" . $settings['pTaxable'] . "'";
            }

            if (!empty($settings['pFeatured'])) {
                $conditions[] = "p.pFeatured = '" . $settings['pFeatured'] . "'";
            }

            $sql = "
                $baseSelect
                $baseFrom
                " . implode(" ", $joins) . "
                WHERE " . implode(" AND ", $conditions) . "
                GROUP BY p.pID
                ORDER BY p.pID DESC
            ";

            $products = $db->fetchAll($sql, $params);

            $xml = new SimpleXMLElement('<?xml version="1.0" encoding="UTF-8"?><rss version="2.0"/>');
            $xml->addAttribute('xmlns:g', 'http://base.google.com/ns/1.0');

            $channel = $xml->addChild('channel');
            $channel->addChild('title', 'Your Store Feed');
            $channel->addChild('link', $baseUrl);
            $channel->addChild('description', 'Product feed for Google Merchant Center');

            foreach ($products as $product) {
                $productu = Product::getByID($product['pID']);
                $page = Page::getByID($productu->getPageID());
                if (!$page || $page->isError()) {
                    continue;
                }

                $url = $page->getCollectionLink();
                $imageUrl = '';
                $image = $productu->getImageObj();
                if (is_object($image)) {
                    $imageUrl = $image->getURL();
                }

                $brand = '';
                if (is_numeric($product['pManufacturer'])) {
                    $manufacturer = $db->fetchAssociative("SELECT * FROM CommunityStoreManufacturer WHERE mID = ?", [$product['pManufacturer']]);
                    if (is_array($manufacturer)) {
                        $brand = $manufacturer['mName'];
                    }
                }

                $item = $channel->addChild('item');
                $item->addChild('g:id', $product['pID'], 'http://base.google.com/ns/1.0');
                $item->addChild('title', htmlspecialchars($product['pName']));
                $item->addChild('description', htmlspecialchars($product['pDesc']));
                $item->addChild('link', htmlspecialchars($url));
                $item->addChild('g:image_link', htmlspecialchars($imageUrl), 'http://base.google.com/ns/1.0');
                $item->addChild('g:availability', 'in stock', 'http://base.google.com/ns/1.0');
                $item->addChild('g:price', $product['pPrice'] . ' USD', 'http://base.google.com/ns/1.0');
                $item->addChild('g:brand', htmlspecialchars($brand), 'http://base.google.com/ns/1.0');
                $item->addChild('g:condition', 'new', 'http://base.google.com/ns/1.0');
            }

            $this->logFeedStatus($db, $config['id'], 'success');
            return new Response($xml->asXML(), 200, ['Content-Type' => 'application/xml']);

        } catch (Exception $e) {
            if (isset($db) && isset($config['id'])) {
                $this->logFeedStatus($db, $config['id'], 'error', $e->getMessage());
            }
            return new Response("Error generating feed: " . $e->getMessage(), 500);
        }
    }
}

—

### ✅ What’s Handled:
– No table creation logic
– `logFeedStatus()` inserts into `shoppingfeedlog`
– Logs success or error with:
– `feed_id`
– `updated_at`
– `status`
– `error_message` (nullable)
– Silently skips logging errors to avoid blocking feed response

Let me know if you want a dashboard view for these logs.

User
namespace ConcretePackageShoppingFeedManagerController;

use ConcreteCoreControllerAbstractController;
use ConcreteCoreDatabaseConnectionConnection;
use SymfonyComponentHttpFoundationResponse;
use ConcretePackageCommunityStoreSrcCommunityStoreProductProduct;
use ConcreteCoreSupportFacadeUrl;
use ConcreteCorePagePage;
use Exception;
use DateTime;

class MerchantFeed extends AbstractController
{
protected function logFeedStatus($db, $feedId, $status, $message = null)
{
try {
$now = (new DateTime())->format('Y-m-d H:i:s');

$db->insert('shoppingfeedlog', [
'feed_id' => $feedId,
'updated_at' => $now,
'status' => $status,
'error_message' => $message
]);
} catch (Exception $logException) {
// Optional: Log error to file or skip silently
// error_log("Feed log error: " . $logException->getMessage());
}
}

public function generateXml($feedSlug = null)
{
$baseUrl = Url::to('/');
$db = Core::make(Connection::class);

try {
if (!$feedSlug) {
throw new Exception("Feed slug is required.");
}

$config = $db->fetchAssociative("SELECT * FROM shoppingfeedconfiguration WHERE feedSlug = ?", [$feedSlug]);
if (!$config) {
throw new Exception("Feed not found.");
}

$settings = unserialize($config['settings']);
$baseSelect = "SELECT p.*";
$baseFrom = "FROM CommunityStoreProducts p";
$joins = [];
$conditions = ["1=1"];
$params = [];

if (!empty($settings['price_range']['min']) && !empty($settings['price_range']['max'])) {
$conditions[] = "p.pPrice BETWEEN ? AND ?";
$params[] = (float)$settings['price_range']['min'];
$params[] = (float)$settings['price_range']['max'];
}

if (!empty($settings['product_groups'])) {
$groupIds = array_map('intval', $settings['product_groups']);
$joins[] = "INNER JOIN CommunityStoreProductGroups pg ON pg.pID = p.pID";
$conditions[] = "pg.gID IN (" . implode(',', $groupIds) . ")";
}

if (!empty($settings['product_types'])) {
$productTypes = array_map('intval', $settings['product_types']);
$conditions[] = "p.pType IN (" . implode(',', $productTypes) . ")";
}

if (!empty($settings['pShippable'])) {
$conditions[] = "p.pShippable = '" . $settings['pShippable'] . "'";
}

if (!empty($settings['pTaxable'])) {
$conditions[] = "p.pTaxable = '" . $settings['pTaxable'] . "'";
}

if (!empty($settings['pFeatured'])) {
$conditions[] = "p.pFeatured = '" . $settings['pFeatured'] . "'";
}

$sql = "
$baseSelect
$baseFrom
" . implode(" ", $joins) . "
WHERE " . implode(" AND ", $conditions) . "
GROUP BY p.pID
ORDER BY p.pID DESC
";

$products = $db->fetchAll($sql, $params);

$xml = new SimpleXMLElement('');
$xml->addAttribute('xmlns:g', 'http://base.google.com/ns/1.0');

$channel = $xml->addChild('channel');
$channel->addChild('title', 'Your Store Feed');
$channel->addChild('link', $baseUrl);
$channel->addChild('description', 'Product feed for Google Merchant Center');

foreach ($products as $product) {
$productu = Product::getByID($product['pID']);
$page = Page::getByID($productu->getPageID());
if (!$page || $page->isError()) {
continue;
}

$url = $page->getCollectionLink();
$imageUrl = '';
$image = $productu->getImageObj();
if (is_object($image)) {
$imageUrl = $image->getURL();
}

$brand = '';
if (is_numeric($product['pManufacturer'])) {
$manufacturer = $db->fetchAssociative("SELECT * FROM CommunityStoreManufacturer WHERE mID = ?", [$product['pManufacturer']]);
if (is_array($manufacturer)) {
$brand = $manufacturer['mName'];
}
}

$item = $channel->addChild('item');
$item->addChild('g:id', $product['pID'], 'http://base.google.com/ns/1.0');
$item->addChild('title', htmlspecialchars($product['pName']));
$item->addChild('description', htmlspecialchars($product['pDesc']));
$item->addChild('link', htmlspecialchars($url));
$item->addChild('g:image_link', htmlspecialchars($imageUrl), 'http://base.google.com/ns/1.0');
$item->addChild('g:availability', 'in stock', 'http://base.google.com/ns/1.0');
$item->addChild('g:price', $product['pPrice'] . ' USD', 'http://base.google.com/ns/1.0');
$item->addChild('g:brand', htmlspecialchars($brand), 'http://base.google.com/ns/1.0');
$item->addChild('g:condition', 'new', 'http://base.google.com/ns/1.0');
}

$this->logFeedStatus($db, $config['id'], 'success');
return new Response($xml->asXML(), 200, ['Content-Type' => 'application/xml']);

} catch (Exception $e) {
if (isset($db) && isset($config['id'])) {
$this->logFeedStatus($db, $config['id'], 'error', $e->getMessage());
}
return new Response("Error generating feed: " . $e->getMessage(), 500);
}
}
}
also log Pdesc as error if its empty and save message with full detail

Assistant
Here's the updated version of your `MerchantFeed` controller with:

✅ Logging of `pDesc` (product description) as an error if it's empty
✅ Full error message saved in the log including product name and ID
✅ Still avoids creating the table – assumes `shoppingfeedlog` already exists

—

### ✅ Updated `generateXml()` Method with `pDesc` Error Logging

// Inside your foreach loop after checking $productu and $page
foreach ($products as $product) {
    $productu = Product::getByID($product['pID']);
    $page = Page::getByID($productu->getPageID());
    if (!$page || $page->isError()) {
        continue;
    }

    $url = $page->getCollectionLink();
    $imageUrl = '';
    $image = $productu->getImageObj();
    if (is_object($image)) {
        $imageUrl = $image->getURL();
    }

    $brand = '';
    if (is_numeric($product['pManufacturer'])) {
        $manufacturer = $db->fetchAssociative("SELECT * FROM CommunityStoreManufacturer WHERE mID = ?", [$product['pManufacturer']]);
        if (is_array($manufacturer)) {
            $brand = $manufacturer['mName'];
        }
    }

    // 🚨 Check for empty description and log it
    if (empty(trim($product['pDesc']))) {
        $errorMessage = sprintf(
            "Missing description for product ID %d (%s). Skipped from feed.",
            $product['pID'],
            $product['pName']
        );
        $this->logFeedStatus($db, $config['id'], 'error', $errorMessage);
        continue; // skip product
    }

    $item = $channel->addChild('item');
    $item->addChild('g:id', $product['pID'], 'http://base.google.com/ns/1.0');
    $item->addChild('title', htmlspecialchars($product['pName']));
    $item->addChild('description', htmlspecialchars($product['pDesc']));
    $item->addChild('link', htmlspecialchars($url));
    $item->addChild('g:image_link', htmlspecialchars($imageUrl), 'http://base.google.com/ns/1.0');
    $item->addChild('g:availability', 'in stock', 'http://base.google.com/ns/1.0');
    $item->addChild('g:price', $product['pPrice'] . ' USD', 'http://base.google.com/ns/1.0');
    $item->addChild('g:brand', htmlspecialchars($brand), 'http://base.google.com/ns/1.0');
    $item->addChild('g:condition', 'new', 'http://base.google.com/ns/1.0');
}

—

### 🔁 No changes needed to `logFeedStatus()` – it already logs message + status.

This will now:
– **Skip any product that has an empty `pDesc`**
– **Log the issue to `shoppingfeedlog`** with meaningful details

Let me know if you want to:
– Log **all products**, not just skipped ones
– Include more fields (like SKU or category)
– Include **XML in response even for error cases**

User
also loggin for
$page = Page::getByID($productu->getPageID());
if (!$page || $page->isError()) {

continue;
}

$url = $page->getCollectionLink();

Assistant
Here's your updated `MerchantFeed` controller with **logging added for invalid or missing product pages** — specifically for this block:

$page = Page::getByID($productu->getPageID());
if (!$page || $page->isError()) {
    // Log here
    continue;
}

### ✅ Full Logging Logic Added:
– Logs when a product has a missing or invalid page
– Includes product ID and name
– Uses the same `logFeedStatus()` function without creating tables

—

### ✅ Final Updated Section of `generateXml()` Method:

foreach ($products as $product) {
    $productu = Product::getByID($product['pID']);

    if (!$productu) {
        $this->logFeedStatus($db, $config['id'], 'error', "Product not found for ID {$product['pID']}");
        continue;
    }

    $pageID = $productu->getPageID();
    $page = Page::getByID($pageID);

    if (!$page || $page->isError()) {
        $this->logFeedStatus($db, $config['id'], 'error', "Missing or invalid page for product ID {$product['pID']} ({$product['pName']}). Page ID: {$pageID}");
        continue;
    }

    $url = $page->getCollectionLink();
    $imageUrl = '';
    $image = $productu->getImageObj();
    if (is_object($image)) {
        $imageUrl = $image->getURL();
    }

    $brand = '';
    if (is_numeric($product['pManufacturer'])) {
        $manufacturer = $db->fetchAssociative("SELECT * FROM CommunityStoreManufacturer WHERE mID = ?", [$product['pManufacturer']]);
        if (is_array($manufacturer)) {
            $brand = $manufacturer['mName'];
        }
    }

    // 🚨 Log missing description
    if (empty(trim($product['pDesc']))) {
        $this->logFeedStatus($db, $config['id'], 'error', "Missing description for product ID {$product['pID']} ({$product['pName']})");
        continue;
    }

    $item = $channel->addChild('item');
    $item->addChild('g:id', $product['pID'], 'http://base.google.com/ns/1.0');
    $item->addChild('title', htmlspecialchars($product['pName']));
    $item->addChild('description', htmlspecialchars($product['pDesc']));
    $item->addChild('link', htmlspecialchars($url));
    $item->addChild('g:image_link', htmlspecialchars($imageUrl), 'http://base.google.com/ns/1.0');
    $item->addChild('g:availability', 'in stock', 'http://base.google.com/ns/1.0');
    $item->addChild('g:price', $product['pPrice'] . ' USD', 'http://base.google.com/ns/1.0');
    $item->addChild('g:brand', htmlspecialchars($brand), 'http://base.google.com/ns/1.0');
    $item->addChild('g:condition', 'new', 'http://base.google.com/ns/1.0');
}

—

### 🔁 Result:
Now you're logging:
– Missing or invalid product page
– Empty product description

Would you also like:
– To log **missing image** URLs?
– To log **successful product entries** (optional auditing)?

User
set false in code
Assistant
To include the `false` tag for each product in your Google Merchant XML feed, simply add the following line inside your loop where you're building each “.

—

### ✅ Final XML Generation Block with `g:identifier_exists`

Here’s the updated part of the `foreach` loop:

$item = $channel->addChild('item');
$item->addChild('g:id', $product['pID'], 'http://base.google.com/ns/1.0');
$item->addChild('title', htmlspecialchars($product['pName']));
$item->addChild('description', htmlspecialchars($product['pDesc']));
$item->addChild('link', htmlspecialchars($url));
$item->addChild('g:image_link', htmlspecialchars($imageUrl), 'http://base.google.com/ns/1.0');
$item->addChild('g:availability', 'in stock', 'http://base.google.com/ns/1.0');
$item->addChild('g:price', $product['pPrice'] . ' USD', 'http://base.google.com/ns/1.0');
$item->addChild('g:brand', htmlspecialchars($brand), 'http://base.google.com/ns/1.0');
$item->addChild('g:condition', 'new', 'http://base.google.com/ns/1.0');

// ✅ Add this tag to declare no GTIN/MPN
$item->addChild('g:identifier_exists', 'false', 'http://base.google.com/ns/1.0');

—

### 🔎 Why this matters
Google requires `g:identifier_exists` to be set to `false` if you don't provide a GTIN, MPN, or brand. You’re already including brand optionally, but this line ensures that products without standard identifiers are still accepted by Google Merchant Center.

Let me know if you also want to dynamically set this based on GTIN/MPN presence.

User
if therre is only 1 product and there description is missing dont generate xml just show message
Assistant
Perfect — here's how to **prevent XML generation when there's only 1 product and its description is missing**, and instead return a message.

—

### ✅ Insert This Check Before XML Generation Loop

Update your code **right after** `$products = $db->fetchAll(…);` like this:

$products = $db->fetchAll($sql, $params);

// Check for single product with missing description
if (count($products) === 1 && empty(trim($products[0]['pDesc']))) {
    $this->logFeedStatus($db, $config['id'], 'error', "Only 1 product found and its description is missing (ID: {$products[0]['pID']}, Name: {$products[0]['pName']}). Feed not generated.");
    return new Response("Cannot generate feed: Only 1 product found and it has no description.", 400);
}

—

### ✅ Keep your `foreach` loop for XML generation exactly as-is after this block.

This ensures:
– If there's **just 1 product** and it has **no description**, you:
– **Skip XML generation**
– **Log the error**
– **Return a plain message with 400 response**

Would you also like to:
– Include a UI warning in the dashboard?
– Optionally fallback to a default description like “No description available”?

User
what if we have more than 1 product and no one has description
Assistant
Great follow-up.

If you want to **also skip XML generation when there are multiple products, but none of them have a description**, you can add an additional check before generating the XML.

—

### ✅ Full Logic to Handle Both Cases:
– ✅ **1 product, and it has no description → don't generate XML**
– ✅ **Multiple products, but none have a description → don't generate XML**

—

### 🔧 Insert This Code After Fetching Products:

$products = $db->fetchAll($sql, $params);

// ✅ Case 1: Only 1 product and its description is missing
if (count($products) === 1 && empty(trim($products[0]['pDesc']))) {
    $this->logFeedStatus(
        $db,
        $config['id'],
        'error',
        "Only 1 product found and its description is missing (ID: {$products[0]['pID']}, Name: {$products[0]['pName']}). Feed not generated."
    );
    return new Response("Cannot generate feed: Only 1 product and its description is missing.", 400);
}

// ✅ Case 2: More than 1 product, but none have a description
$hasAtLeastOneWithDesc = false;
foreach ($products as $p) {
    if (!empty(trim($p['pDesc']))) {
        $hasAtLeastOneWithDesc = true;
        break;
    }
}
if (!$hasAtLeastOneWithDesc) {
    $this->logFeedStatus(
        $db,
        $config['id'],
        'error',
        "Multiple products found but none have a description. Feed not generated."
    );
    return new Response("Cannot generate feed: All products are missing descriptions.", 400);
}

—

### ✅ Then continue with your XML generation loop as usual.

This ensures you:
– Don’t generate an empty or invalid feed
– Have detailed logs for debugging
– Return meaningful HTTP 400 responses

Let me know if you'd like to include the product IDs/names in the second case log too.

Leave a Comment

Your email address will not be published. Required fields are marked *